Item Sorting II (Final Fantasy VII)

[P3k]

Hey,
I didn't want to necro this post: https://forums.qhimm.com/index.php?topic=16079.msg226836#msg226836 so thought I'd make a new one.

I hope anyone can help me understand specifically what NFITC1 means about the bubble sort and field / battle condition.

If I do the bubble sort based on the field condition, I do not get the same results as the game.

Can someone please explain how NFITC1's answer would function? Do I check the condition once then BS from there or am i missing something?

Here's my code;

Code: [Select]

for (var i = player.inventory.items.Length; i > 0; i--)
{
  for (var j = player.inventory.items.Length - 1; j >= 0; j--)
  {
    if (j != 0)
    {
      var i1 = player.inventory.items[j];
      var i2 = player.inventory.items[j - 1];

      var swapID = ShouldSwap(i1, i2);

      if (swapID == 1)
      {
        player.inventory.items[j] = i2;
        player.inventory.items[j - 1] = i1;
      }
    }
  }
}

private static int ShouldSwap(
  Player.PlayerInventory.InventoryItem item1,
  Player.PlayerInventory.InventoryItem item2)
{
  if (item1.sortTag.Contains(SortingTag.Field))
  {
    return item2.sortTag.Contains(SortingTag.Field) ?0 : 1;
  }
  else
  {
    return item2.sortTag.Contains(SortingTag.Field) ?-1 : 0;
  }
}

Cheers

[P3k]

I figured it out.

NFITC1: Item1 starts at 319 and item2 starts at 318

The above is incorrect. item1 always starts from 319 while item2 is the next inventory index to search.
E.G;
item1 = 319 to 0, item2 = 0
item1 = 319 to 0, item2 = 1

Once item1's inventory index is < than item2's, end the sorting function for that index.

Code: [Select]

var length = player.inventory.items.Length - 1;

/// Start at first inventory index (item2)
for (var i = 0; i <= length; i++)
{
 
  /// Cycle through inventory from end to start (item1), searching for an item that can be swapped with item2.
  for (var j = length ; j >= 0; j--)
  {
      var i1 = player.inventory.items[j];
      var i2 = player.inventory.items[i];

      var swapID = ShouldSwap(i1, i2);
     
      /// As long as the search index is greater than the index of that which is being replaced,
      /// run condition to see if a swap is required
      if(j > i)
      { 
         if (swapID == 1)
         {
   player.inventory.items[i] = i1;
     player.inventory.items[j] = i2;
         }
      }
      /// If the search index becomes less than the index of which is being replaced, end the sorting of this index
      else
      { break; }
  }
}

So essentially, starting from the top index, search for an item to replace it with by searching all inventory index's starting from the bottom. If the search index gets < than that of what it is trying to replace, end the sort for that index, then start again from the next top index.
 

[P3k]

I was able to decompile FF7 and find the function that arranges the Inventory.
It took me a few days (as I'm a newb at assembly) but I got there in the end and managed to perfectly replicate the sorting methods.

If anyone is interested, you can find my script here: https://github.com/p3k22/FF7-Csharp/blob/main/FF7%20Arrange%20Inventory.cs